Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

회고 서비스 작성 #22

Closed
wants to merge 24 commits into from
Closed

회고 서비스 작성 #22

wants to merge 24 commits into from

Conversation

sjhjack
Copy link
Contributor

@sjhjack sjhjack commented Sep 22, 2024

📑 개요

✅ PR 체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

🚀 상세 작업 내용

  • Review Controller, Service 위치 변경
     - domain.jpamongo-review-domain -> application.wypl-core
  • WyplCoreApplication 위치 변경 -> basePackages 적용
  • Request, Response Record 추가, 리뷰 타입 Enum 추가
  • Service, Repository 마이그레이션
     - 회고 조회, 작성, 수정, 삭제 기능
     - MemberSchedule 관련 로직 수정
  • ReviewUtils 추가
     - 리뷰id, 멤버id에 해당하는 회고 조회
  • Review Exception 추가
     - 회고 컨텐츠 검증 로직
     - 회고 존재 여부 검증 로직

📁 ETC

@sjhjack
Refactor(#21): import 대상 변경
fec9315
@sjhjack
Refactor(#21): Object -> ReviewContent 변경
e84f5d6
@sjhjack
Refactor(#21): Schedule 컬럼 추가
ad21587
@sjhjack
Feat(#21): starter-web 추가
6e2f53e
@sjhjack
Chore(#21): SpringBootApplication 위치 변경
f2ee49e
@sjhjack
Chore(#21): Repository 어노테이션 추가
9a54021
@sjhjack
Chore(#21): wypl-core에 도메인 추가
4f7d11e
@sjhjack
Feat(#21): review request dto 추가
06e1f2b
@sjhjack
Feat(#21): review response dto 추가
db46347
@sjhjack
Feat(#21): review service interface 추가
f7f6b41
@sjhjack
Chore(#21): domain 단에서 web 제거
2e68e0b
@sjhjack
Refactor(#21): Member Entity에 Getter 추가 및 import 스타일 변경
9a835d0
@sjhjack
Feat(#21): Review Entity에 of, updateTitle 메서드 추가
02a7cfa
@sjhjack
Feat(#21): ReviewContents Document에 of, updateContents 메서드 추가
f894c6f
@sjhjack
Refactor(#21): 파라미터 id값 타입 int -> long 변경
d2975f0
@sjhjack
Refactor(#21): ReviewResponse의 썸네일 타입 Object -> ReviewContent 변경
1308d6e
@sjhjack
Refactor(#21): ReviewController 위치 변경
e728b56
@sjhjack
Feat(#21): ReviewException 추가
e11edb9
@sjhjack
Feat(#21): Review Service, Repository 추가(MemberSchedule 제거)
b514883
@sjhjack
Refactor(#21): ReviewDetailResponse의 members 제거
bf8f5cd
@sjhjack
Refactor(#21): ReviewServiceImpl에 ReviewUtils 적용
6ebb67c
@sjhjack
Refactor(#21): getReviewsByScheduleId 내부 로직 수정
1ed48db
@sjhjack sjhjack self-assigned this Sep 22, 2024
@sjhjack sjhjack linked an issue Sep 22, 2024 that may be closed by this pull request
회고 기능 작성 #21
Closed
@github-actions GitHub Actions
Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

KIMSEI1124
KIMSEI1124 requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

궁금한 사항을 달아놨습니다!

한번 보시고 알려주세요!

application/wypl-core/src/main/java/com/wypl/wyplcore/review/exception/ReviewException.java Outdated Show resolved Hide resolved
application/wypl-core/src/main/java/com/wypl/wyplcore/review/service/ReviewReadService.java Show resolved Hide resolved
application/wypl-core/src/main/java/com/wypl/wyplcore/review/service/ReviewServiceImpl.java Outdated Show resolved Hide resolved
application/wypl-core/src/main/java/com/wypl/wyplcore/review/service/ReviewServiceImpl.java Show resolved Hide resolved
...jpamongo-review-domain/src/main/java/com/wypl/jpamongoreviewdomain/review/domain/Review.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

@sjhjack
Copy link
Contributor Author

sjhjack commented Sep 22, 2024

@sjhjack sjhjack closed this Sep 22, 2024
@sjhjack sjhjack deleted the feat/#21 branch September 22, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMSEI1124 KIMSEI1124 KIMSEI1124 requested changes

@jiwon83 jiwon83 Awaiting requested review from jiwon83

Assignees

@sjhjack sjhjack

Labels
Module: Core Server Status: Review Needed Type: ✨ Feature 새로운 기능 추가
Projects
What's Your Plan
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

회고 기능 작성
2 participants
@sjhjack @KIMSEI1124